Arbos v32 debug #2671
Open
Arbos v32 debug #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
PlasmaPower
requested changes
Sep 17, 2024
| @@ -332,6 +331,9 @@ func (state *ArbosState) UpgradeArbosVersion( | |||
| ensure(params.UpgradeToVersion(2)) | |||
| ensure(params.Save()) | |||
|
|
|||
| case 32: | |||
| // no change state needed | |||
There was a problem hiding this comment.
This needs to return an error if it's not a debug chain, otherwise out-of-date nodes will process the upgrade. We could just generally error if the version we're upgrading to is less than MaxArbosVersionSupported. That might be the way to go.
Stylus gas ink fixes
Stylus activation pricing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does only initial work to declare the existance of a (currently debug-only) arbos v32, under the constant ArbosVersion_StylusChargingFixes
pulls in: OffchainLabs/go-ethereum#360